Testrepository

Merge lp://staging/~treinish/testrepository/testrepository-group-regex into lp://staging/~testrepository/testrepository/trunk

  1. testrepository-group-regex
  2. Merge into trunk
Proposed by Matthew Treinish
Status: Merged
Merged at revision: 231
Proposed branch: lp://staging/~treinish/testrepository/testrepository-group-regex
Merge into: lp://staging/~testrepository/testrepository/trunk
Diff against target: 324 lines (+161/-16)
5 files modified
COPYING (+1/-0)
NEWS (+3/-0)
doc/MANUAL.txt (+24/-0)
testrepository/testcommand.py (+93/-16)
testrepository/tests/test_testcommand.py (+40/-0)
To merge this branch: bzr merge lp://staging/~treinish/testrepository/testrepository-group-regex
Reviewer Review Type Date Requested Status
Robert Collins Needs Fixing
Review via email: mp+173749@code.staging.launchpad.net

Description of the change

Not sure; putting up for review as I've been asked to review it via IRC :)

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

This is better, but now overly complex: rather than tangling together the regex nature and the grouping, it would be better to improve the core scheduler to take groups rather than adding a parallel codepath.

I have a bit of time this evening so I'm going to see about taking your work as input and iterating on it.

A little meta-hint too; you added some spurious vertical whitespace (e.g. after docstrings), trailing whitespace and didn't update docstrings consistently, all of which would be needed to be fixed before landing.

review: Needs Fixing
Revision history for this message
Robert Collins (lifeless) wrote :

There's another interaction we need to document at least, which is that running just some tests with the grouping facility will break when a test suite requires all the tests in a group together. That can be done later (and it really indicates a buggy test suite...)

Revision history for this message
Robert Collins (lifeless) wrote :

Oh, and the documentation still needs to be added.

Revision history for this message
Robert Collins (lifeless) wrote :

oh, I'm blind, there are docs. Woo. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches