Ubuntu UI Toolkit

Merge lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro into lp://staging/ubuntu-ui-toolkit

panel-opened-ro
Merge into trunk

Proposed by Tim Peeters on 2013-09-09

Status:	Merged
Approved by:	Zoltan Balogh on 2013-09-23
Approved revision:	761
Merged at revision:	754
Proposed branch:	lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro
Merge into:	lp://staging/ubuntu-ui-toolkit
Diff against target:	194 lines (+37/-27) 5 files modified CHANGES (+1/-1) modules/Ubuntu/Components/Panel.qml (+30/-21) tests/resources/navigation/MyCustomPage.qml (+1/-1) tests/resources/toolbar/panels.qml (+2/-1) tests/unit/tst_components/tst_toolbar.qml (+3/-3)
To merge this branch:	bzr merge lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro
Related bugs:	Link a bug report
Related blueprints:	New toolbar open/close behavior (Medium)

Reviewer	Review Type	Status
PS Jenkins bot	continuous-integration	Approve on 2013-09-23
Tim Peeters		Approve on 2013-09-16
Zsombor Egri		Approve on 2013-09-12
Review via email: mp+184663@code.staging.launchpad.net

Commit message

Smarter automatic updating of Panel's opened property.

Panel.open() and Panel.close() should be used to open/close a Panel, or when using a toolbar with ToolbarItems from a Page, set Page.tools.opened to open/close the toolbar.

No API or behavior changes since the panel-open-close branch. Toolbar behavior changes will be done in a following MR.

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-09:

work in progress, don't approve.

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-09

751. By Tim Peeters on 2013-09-09: remove commented-out code
752. By Tim Peeters on 2013-09-09: merge panel-open-close branch
753. By Tim Peeters on 2013-09-09: make opened property read-write again to avoind API breaks, and re-bind its value when it is updated
754. By Tim Peeters on 2013-09-09: semicolon
755. By Tim Peeters on 2013-09-09: update toolbar tests

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-09:

done, but merge this one first: https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/panel-open-close/+merge/183892

Taking very small steps to avoid app (+tests) breakage.

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-09

756. By Tim Peeters on 2013-09-09: formatting
757. By Tim Peeters on 2013-09-09: formatting

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-09:

FAILED: Continuous integration, rev:750
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/625/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3210/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/757/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/482/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/482/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3216/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/759/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/625/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-09:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/627/rebuild

review: Approve (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-11:

gallery-app autopilot tests PASSED on pending image of 11 sept.

webbrowser-app autopilot tests FAILED on pending image of 11 sept. Log: https://pastebin.canonical.com/97312/

review: Needs Fixing

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-12

758. By Tim Peeters on 2013-09-12: fix typo in CHANGES

Revision history for this message

Zsombor Egri (zsombi) wrote on 2013-09-12:

Code looks good, runs well, let me know if you have anything to add/change so I can top-approve!

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-12:

FAILED: Continuous integration, rev:758
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/646/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3345
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/884
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/503
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/503
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/503/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3353
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3353/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2825
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/886
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/886/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/735
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/745

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/646/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-12

759. By Tim Peeters on 2013-09-12: re-trigger jenkins

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-12:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/648/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-12:

So, after changing one line in CHANGES (not a code update), jenkins gives completely different results than it did before.

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-16

760. By Tim Peeters on 2013-09-16: re-trigger jenkins

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-16:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/650/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-16:

webbrowser autopilot test passes with 20130913 image.

Fails with that image and this MR: https://pastebin.canonical.com/97519/

Packages from this MR pass webbrowser autopilot tests with this pending version of webbrowser-app: https://code.launchpad.net/~osomon/webbrowser-app/new-panel-api/+merge/185222

review: Approve

Revision history for this message

Tim Peeters (tpeeters) wrote on 2013-09-16:

autopilot tests also PASSED for:
- gallery_app
- notes_app
- dialer_app
- messaging_app

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-16:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/656/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tpeeters/ubuntu-ui-toolkit/panel-opened-ro updated on 2013-09-17

761. By Tim Peeters on 2013-09-17: another try with CI. Failures seem not related to the code changes. Maybe something outside the UITK got fixed in the meanwhile.