Ubuntu UI Toolkit

Merge lp://staging/~tpeeters/ubuntu-ui-toolkit/fixOskAnchors into lp://staging/ubuntu-ui-toolkit

  1. fixOskAnchors
  2. Merge into trunk
Proposed by Tim Peeters
Status: Rejected
Rejected by: Zoltan Balogh
Proposed branch: lp://staging/~tpeeters/ubuntu-ui-toolkit/fixOskAnchors
Merge into: lp://staging/ubuntu-ui-toolkit
Diff against target: 122 lines (+21/-55)
1 file modified
modules/Ubuntu/Components/OrientationHelper.qml (+21/-55)
To merge this branch: bzr merge lp://staging/~tpeeters/ubuntu-ui-toolkit/fixOskAnchors
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Zoltan Balogh Disapprove
Review via email: mp+226275@code.staging.launchpad.net

Description of the change

Revert speed optimizations for orientation changes which caused an OSK anchoring regression.

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK

review: Approve
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

kaleo has better solution

review: Disapprove
Revision history for this message
Florian Boucault (fboucault) wrote :

https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/fix_overlap_osk/+merge/226286 overrides it

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1053
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/2106/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1795/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1513
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-amd64-ci/52
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-utopic-armhf-ci/52/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2058/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2872
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2872/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9610
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1266
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1700
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1700/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/2106/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

1053. By Tim Peeters

link bugs

1052. By Tim Peeters

revert r1109 of staging

1051. By Tim Peeters

revert r1112 of staging

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: