Merge lp://staging/~tpeeters/ubuntu-ui-toolkit/80-betterActive into lp://staging/ubuntu-ui-toolkit/staging
Proposed by
Tim Peeters
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Zsombor Egri | ||||||||||||
| Approved revision: | 1060 | ||||||||||||
| Merged at revision: | 1048 | ||||||||||||
| Proposed branch: | lp://staging/~tpeeters/ubuntu-ui-toolkit/80-betterActive | ||||||||||||
| Merge into: | lp://staging/ubuntu-ui-toolkit/staging | ||||||||||||
| Diff against target: |
198 lines (+55/-12) 7 files modified
components.api (+1/-0) modules/Ubuntu/Components/MainView.qml (+5/-1) modules/Ubuntu/Components/Page.qml (+2/-0) modules/Ubuntu/Components/PageStack.qml (+11/-0) modules/Ubuntu/Components/PageTreeNode.qml (+10/-8) tests/unit/tst_components/tst_pagestack.qml (+23/-3) tests/unit/tst_mainview/PageStack.qml (+3/-0) |
||||||||||||
| To merge this branch: | bzr merge lp://staging/~tpeeters/ubuntu-ui-toolkit/80-betterActive | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Zsombor Egri | Approve | ||
|
Review via email:
|
|||
Commit message
Improve automatic setting of the active property of Pages, Tabs, PageStack.
Pages defined as children of PageStack are now not active by default until they are pushed on the stack, and inactive pages are not visible.
Description of the change
Improve automatic setting of the active property of Pages, Tabs, PageStack.
Pages defined as children of PageStack are now not active by default until they are pushed on the stack, and inactive pages are not visible.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:1051
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://