Whoopsie

Merge lp://staging/~toykeeper/whoopsie/uploaded-url into lp://staging/whoopsie

uploaded-url
Merge into trunk

Proposed by Selene ToyKeeper on 2016-05-17

Status:	Merged
Merged at revision:	699
Proposed branch:	lp://staging/~toykeeper/whoopsie/uploaded-url
Merge into:	lp://staging/whoopsie
Diff against target:	156 lines (+34/-7) 6 files modified src/monitor.c (+2/-2) src/tests/test_utils.c (+1/-1) src/utils.c (+5/-1) src/utils.h (+1/-1) src/whoopsie.c (+24/-2) src/whoopsie.h (+1/-0)
To merge this branch:	bzr merge lp://staging/~toykeeper/whoopsie/uploaded-url
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Murray		2016-05-17	Disapprove on 2018-11-19
Review via email: mp+294865@code.staging.launchpad.net

Description of the change

Fix bug 1582470 (should put OOPS ID / URL in .uploaded file)

Intended to make it easier for both scripts and humans to map crash dump files to OOPS IDs and errors.ubuntu.com URLs, by storing that data in the .uploaded file created after a successful upload.

To test, force a crash, wait for whoopsie upload (or do a whoopsie-upload-all), then ensure the OOPS ID and URL are in the matching .uploaded file.

Revision history for this message

Selene ToyKeeper (toykeeper) wrote on 2016-05-17:

Not actually ready yet; I still need to build it, test it, get feedback on how to properly implement it, then possibly rewrite it.

lp://staging/~toykeeper/whoopsie/uploaded-url updated on 2016-05-17

681. By Selene ToyKeeper on 2016-05-17: oops, use fprintf() instead of write()

Revision history for this message

Brian Murray (brian-murray) wrote on 2016-05-17:

I've added a comment about hard coding errors.ubuntu.com.

Revision history for this message

Brian Murray (brian-murray) wrote on 2018-11-19:

There were quite a few issues with this branch as implemented but I went ahead and used it as a basis for adding this functionality to whoopsie so thanks!

review: Disapprove