Merge lp://staging/~toykeeper/qlbr/support-extras into lp://staging/qlbr

Proposed by Selene ToyKeeper
Status: Needs review
Proposed branch: lp://staging/~toykeeper/qlbr/support-extras
Merge into: lp://staging/qlbr
Diff against target: 518 lines (+306/-42)
9 files modified
README (+1/-1)
qlbr/__init__.py (+15/-0)
qlbr/local_settings_example.py (+2/-0)
qlbr/management/commands/__init__.py (+9/-4)
qlbr/management/commands/get_task_data.py (+2/-15)
qlbr/templates/qlbr/qa-default.html (+79/-14)
qlbr/urls.py (+136/-4)
qlbr/views.py (+25/-4)
searches.json (+37/-0)
To merge this branch: bzr merge lp://staging/~toykeeper/qlbr/support-extras
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Selene ToyKeeper (community) Needs Resubmitting
Allan LeSage Pending
Review via email: mp+207715@code.staging.launchpad.net

Commit message

Lots of updates from the QA sprint:
 - Lots of specific reports added.
 - Added search by multiple statuses, and synced the javascript buttons with report parameters.
 - Made it possible to run authenticated, to see private bugs.
 - Added 'updated' column, simplified date formats.
 - Page title configurable per-report.
 - Gather data from more projects and tags.
 - Minor refactor

Description of the change

Lots of updates from the QA sprint:
 - Lots of specific reports added.
 - Added search by multiple statuses, and synced the javascript buttons with report parameters.
 - Made it possible to run authenticated, to see private bugs.
 - Added 'updated' column, simplified date formats.
 - Page title configurable per-report.
 - Gather data from more projects and tags.
 - Minor refactoring.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Some of the indentation doesn't look uniform on lines 132-165, so if you intentionally changed that, maybe we could clean it up a bit. Not a huge deal, since the page works, and I've got another merge incoming after this that can fix that if needed.

Have you run flake8 on the python sections? Some of the alignment there looks off to me as well, but I may be incorrect.

I'll ask Allan to take a look as well, but this looks generally good to me. I think we may want to re-enable the ability to dynamically show or hide the header, but we can figure that out in the other stuff I'm working on landing.

65. By Selene ToyKeeper

cleaned up template indentation

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

Ah, good catch. I was fighting with vim in the template, since it didn't know how to parse the mixed language. Fixed.

I hadn't run flake8 either, but it looks like the changes are primarily because vim is configured according to somewhat different rules than flake8. (indents are always a multiple of 4 spaces, usually 1 indent for functions and classes and control structures but generally 2 for lists and tuples and such) I'll flake-ify it and re-push.

66. By Selene ToyKeeper

fixed flake8 complaints

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

Flake'd, and ready to go.

review: Needs Resubmitting
Revision history for this message
Max Brustkern (nuclearbob) wrote :

The template indentation still looks weird to me, but maybe Allan has thoughts on that. The rest of it looks good to me.

review: Approve

Unmerged revisions

66. By Selene ToyKeeper

fixed flake8 complaints

65. By Selene ToyKeeper

cleaned up template indentation

64. By Selene ToyKeeper

Added report for elopio's bugs. Made qa-untriaged only include qa-touch bugs.

63. By Selene ToyKeeper

Added/fixed a bunch of reports:
  + tagged with qa-touch
  + recently-created qa-touch bugs
  + recently-closed qa-touch bugs
  + recently-active qa-touch bugs
  + fixed qa-touch bugs which haven't landed for 2+ weeks
  + fixed support bugs which haven't landed for 2+ weeks
  + all bugs
  + critical bugs which aren't assigned to anyone
  * fixed support "new bugs" to include already-fixed ones
  * recently-closed support bugs instead of all closed support bugs

62. By Selene ToyKeeper

Added 'Updated' column to main view. Simplified date formats.

61. By Selene ToyKeeper

Moved LP task status list into one place, ish.
Made template status checkboxes updated based on report parameters.
Added a way to search by multiple statuses (OR, not AND).
Added 'new', 'closed', 'updated', 'needs attention' support reports.
Improved results for support 'untriaged' report (now includes 'confirmed').
Made terminal-state bugs show up in reports where they should be seen.

60. By Selene ToyKeeper

Added quick links for defined reports.
Added report for un-triaged support bugs.

59. By Selene ToyKeeper

Added some simple support-related reports.
Made the page title configurable per URL pattern.

58. By Selene ToyKeeper

added u1-support search

57. By Selene ToyKeeper

Added LP_ANON setting, in case you want to access private bugs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches