lrt

Merge lp://staging/~toykeeper/lrt/add-reboot-test into lp://staging/lrt

  1. add-reboot-test
  2. Merge into trunk
Proposed by Selene ToyKeeper
Status: Needs review
Proposed branch: lp://staging/~toykeeper/lrt/add-reboot-test
Merge into: lp://staging/lrt
Diff against target: 1178 lines (+1158/-0)
4 files modified
reboot-test/COPYING (+674/-0)
reboot-test/README (+21/-0)
reboot-test/reboot-test.py (+457/-0)
reboot-test/reboot-test.sh (+6/-0)
To merge this branch: bzr merge lp://staging/~toykeeper/lrt/add-reboot-test
Reviewer Review Type Date Requested Status
Canonical Platform QA Team Pending
Review via email: mp+259442@code.staging.launchpad.net

Commit message

Added a reboot stress test.
Not yet complete, but works well enough to get some useful results.

Description of the change

Added a reboot stress test.
Not yet complete, but works well enough to get some useful results.

To post a comment you must log in.
lp://staging/~toykeeper/lrt/add-reboot-test updated
101. By Selene ToyKeeper

Fixed a bug where crash dump collector would sometimes miss files
(and then delete them despite the failed transfer).

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I have a bunch of questions! I can keep working with this as we work on getting it landed. I'm trying to have a daily job setup for it by EOD.

Reply
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'm working on a version that'll do NFSS uploads. I started by addressing all the flake8 stuff, and pushed it here:
lp:~canonical-platform-qa/lrt/add-reboot-test
We can figure out whether to work from that or merge other changes you make into it. I also had some additional thoughts.

Reply
Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

I'll re-push after addressing some of the comments below. I also made it work with python3.

Reply
lp://staging/~toykeeper/lrt/add-reboot-test updated
102. By Selene ToyKeeper

Addressed some review comments...
Added GPL.
Added -o / --out option to set the results dir.
Converted fatal error to an exception.
Tiny amount of refactoring.

103. By Selene ToyKeeper

PEP8 fixes (except for visual indent).
Also made 'adb shell never returned' error more useful when failing during shutdown.

104. By Selene ToyKeeper

Made reboot-test work on both python2 and python3.
Added --delete to remove output dir before running test.
Cleaned up run() a little.
Forced LANG because it doesn't work on LANG=C any more.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Responding to old diff comments, looking at new diff now.

Reply
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Only a few comments on the updates.

Reply

Unmerged revisions

104. By Selene ToyKeeper

Made reboot-test work on both python2 and python3.
Added --delete to remove output dir before running test.
Cleaned up run() a little.
Forced LANG because it doesn't work on LANG=C any more.

103. By Selene ToyKeeper

PEP8 fixes (except for visual indent).
Also made 'adb shell never returned' error more useful when failing during shutdown.

102. By Selene ToyKeeper

Addressed some review comments...
Added GPL.
Added -o / --out option to set the results dir.
Converted fatal error to an exception.
Tiny amount of refactoring.

101. By Selene ToyKeeper

Fixed a bug where crash dump collector would sometimes miss files
(and then delete them despite the failed transfer).

100. By Selene ToyKeeper

Minor comment cleaning.

99. By Selene ToyKeeper

Imported reboot test from my +junk branch.
It's not finished, but it does work well enough to get useful results.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches