Unity

Merge lp://staging/~townsend/unity/fix-lp1036614 into lp://staging/unity

fix-lp1036614
Merge into trunk

Proposed by Christopher Townsend on 2013-06-19

Status:

Merged

Approved by:

Brandon Schaefer on 2013-06-21

Approved revision:

no longer in the source branch.

Merged at revision:

3381

Proposed branch:

lp://staging/~townsend/unity/fix-lp1036614

Merge into:

lp://staging/unity

Diff against target:

93 lines (+38/-1)

2 files modified

plugins/unityshell/src/unityshell.cpp (+34/-1)
plugins/unityshell/src/unityshell.h (+4/-0)

To merge this branch:

bzr merge lp://staging/~townsend/unity/fix-lp1036614

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Brandon Schaefer (community)		2013-06-19	Approve on 2013-06-21
MC Return (community)			Approve on 2013-06-20
PS Jenkins bot (community)	continuous-integration		Approve on 2013-06-19
Review via email: mp+170415@code.staging.launchpad.net

Commit message

Draw the full panel shadow when there are windows docked on the panel and no focused windows on the screen such as when the desktop has been clicked.

Description of the change

== Issue ==
When windows are docked on (or very near) the panel and no windows are focused, ie, the desktop has been clicked, the panel shadow is not drawn over the window decorations.

== Fix ==
Following the design recommended in https://bugs.launchpad.net/bugs/1036614, the panel shadow is now drawn over any windows docked on or very near the panel when the desktop has focus.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-06-19:

PASSED: Continuous integration, rev:3379
http://jenkins.qa.ubuntu.com/job/unity-ci/145/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-armhf-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-saucy-i386-ci/33

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-ci/145/rebuild

review: Approve (continuous-integration)

Revision history for this message

MC Return (mc-return) wrote on 2013-06-20:

You could merge these ifs:

60 + if (top_visible_window)
61 + {
62 + if (window->id() == top_visible_window->id())
63 + {
64 + draw_panel_shadow = DrawPanelShadow::OVER_WINDOW;
65 + uScreen->panelShadowPainted = CompRegion();
66 + }

if (top_visible_window &&
window->id() == top_visible_window->id())

Note: This recommendation is not essential, but it is all I found ;)

The rest LGTM. +1

review: Approve

Revision history for this message

Brandon Schaefer (brandontschaefer) wrote on 2013-06-21:

LGTM

review: Approve

Revision history for this message

Sebastien Bacher (seb128) wrote on 2013-06-26:

not sure if that's due to this commit, but things are a bit buggy since recently in saucy:

- click on the background image