Merge lp://staging/~townsend/unity/fix-lp1036614 into lp://staging/unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3381
Proposed branch: lp://staging/~townsend/unity/fix-lp1036614
Merge into: lp://staging/unity
Diff against target: 93 lines (+38/-1)
2 files modified
plugins/unityshell/src/unityshell.cpp (+34/-1)
plugins/unityshell/src/unityshell.h (+4/-0)
To merge this branch: bzr merge lp://staging/~townsend/unity/fix-lp1036614
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
MC Return (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email:

Commit message

Draw the full panel shadow when there are windows docked on the panel and no focused windows on the screen such as when the desktop has been clicked.

Description of the change

== Issue ==
When windows are docked on (or very near) the panel and no windows are focused, ie, the desktop has been clicked, the panel shadow is not drawn over the window decorations.

== Fix ==
Following the design recommended in, the panel shadow is now drawn over any windows docked on or very near the panel when the desktop has focus.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
MC Return (mc-return) wrote :

You could merge these ifs:

60 + if (top_visible_window)
61 + {
62 + if (window->id() == top_visible_window->id())
63 + {
64 + draw_panel_shadow = DrawPanelShadow::OVER_WINDOW;
65 + uScreen->panelShadowPainted = CompRegion();
66 + }


if (top_visible_window &&
    window->id() == top_visible_window->id())

Note: This recommendation is not essential, but it is all I found ;)

The rest LGTM. +1

review: Approve
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :


review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

not sure if that's due to this commit, but things are a bit buggy since recently in saucy:

- click on the background image

-> the panel loose its border, is that wanted?

- click on an indicator

-> the menu is rendered as being "in background" from the panel, it should not

Revision history for this message
Christopher Townsend (townsend) wrote :


You're right and I do think it's caused by my MP here. I'll create a new bug and see if I can get this regression fixed.


Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.