Merge lp://staging/~townsend/unity/fix-dash-no-expand-category into lp://staging/unity

Proposed by Christopher Townsend
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3996
Proposed branch: lp://staging/~townsend/unity/fix-dash-no-expand-category
Merge into: lp://staging/unity
Diff against target: 115 lines (+50/-2)
4 files modified
dash/DashView.cpp (+34/-0)
dash/DashView.h (+2/-0)
dash/PlacesGroup.cpp (+13/-2)
dash/PlacesGroup.h (+1/-0)
To merge this branch: bzr merge lp://staging/~townsend/unity/fix-dash-no-expand-category
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Marco Trevisan (Treviño) Approve
Review via email: mp+258289@code.staging.launchpad.net

Commit message

When using keyboard navigation in the Dash, skip category headers that are not expandable. Also, do not highlight the category header when the mouse cursor is over it.

Description of the change

Note: I ran the unity.tests.test_dash Autopilot tests against this branch with no failures.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Mh so now using tab on dash results, if the header is not expandable, then the tab highlights the first item on that category... Is this something expected?

I like it (I was worried this was causing the focus to jump to the next selectable category), but just to be sure...

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.