Ubuntu
nautilus-share package

Merge lp://staging/~townsend/ubuntu/saucy/nautilus-share/fix-lp1214534 into lp://staging/ubuntu/saucy/nautilus-share

  1. Saucy (13.10)
  2. fix-lp1214534
  3. Merge into saucy
Proposed by Christopher Townsend
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp://staging/~townsend/ubuntu/saucy/nautilus-share/fix-lp1214534
Merge into: lp://staging/ubuntu/saucy/nautilus-share
Diff against target: 1621 lines (+1566/-2)
6 files modified
.pc/04_change_share_labels.patch/src/nautilus-share.c (+1526/-0)
.pc/applied-patches (+1/-0)
debian/changelog (+9/-0)
debian/patches/04_change_share_labels.patch (+27/-0)
debian/patches/series (+1/-0)
src/nautilus-share.c (+2/-2)
To merge this branch: bzr merge lp://staging/~townsend/ubuntu/saucy/nautilus-share/fix-lp1214534
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
Ubuntu branches Pending
Review via email: mp+181160@code.staging.launchpad.net

Commit message

* Add debian/patches/04_change_share_labels.patch
  + Ayatana Design requests that "Sharing Options" and "Share" in Nautilus properties
    be changed to "Local Network Share" to avoid user confusion about sharing.

Description of the change

Ayatana Design (John Lea) has requested that the "Sharing Options" in the right-click menu and "Share" in the Nautilus properties tab be changed to "Local network share".

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work.

I know that Ubuntu Touch is using "sentence case" style, but nautilus is not ... we should probably keep the style consistent within a same application, can you rename those label to "Local Network Share" (otherwise we would have all the other items in the menu and tabs have a different case style from that one string)?

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

(setting to "work in progress", please set it back to "needs review" when you update it)

Revision history for this message
Christopher Townsend (townsend) wrote :

@Sebastien,

Thanks for reviewing this. I will have to get John Lea to ack the case change you are requesting. Once I get his ack, then I'll fix this up, that is unless he has a problem with this:)

Thanks!

Revision history for this message
Christopher Townsend (townsend) wrote :

I never got an ack from John Lea, but I really don't think this will be an issue since this case format is the convention.

Revision history for this message
Christopher Townsend (townsend) wrote :

@Sebastien,

Any more comments on this and if good, any way to sponsor it?

Thanks!

Revision history for this message
Sebastien Bacher (seb128) wrote :

Sorry Chritopher, that got delayed for different reason and we are past string/UI freeze. Do you want to ask for a UIFe (https://wiki.ubuntu.com/UserInterfaceFreeze) or should we delay to next cycle?

Revision history for this message
Christopher Townsend (townsend) wrote :

Hi Sebastien,

Let's just wait for next cycle on this. I'll be sure to remind you:)

Revision history for this message
Sebastien Bacher (seb128) wrote :

> I'll be sure to remind you:)

I'm going to try to get to it early, we made you wait/have to ping enough this cycle ... sorry again about that!

Revision history for this message
Sebastien Bacher (seb128) wrote :

Uploaded to trusty, thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches