Merge lp://staging/~townsend/compiz/fix-snap-window-resize-0.9.10 into lp://staging/compiz/0.9.10
Status: | Merged |
---|---|
Approved by: | Marco Trevisan (Treviño) |
Approved revision: | 3795 |
Merged at revision: | 3796 |
Proposed branch: | lp://staging/~townsend/compiz/fix-snap-window-resize-0.9.10 |
Merge into: | lp://staging/compiz/0.9.10 |
Diff against target: |
81 lines (+0/-71) 1 file modified
plugins/snap/src/snap.cpp (+0/-71) |
To merge this branch: | bzr merge lp://staging/~townsend/compiz/fix-snap-window-resize-0.9.10 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brandon Schaefer (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+189157@code.staging.launchpad.net |
Commit message
Remove seemingly useless code in the SnapWindow:
Description of the change
= Issue =
Set Default Resizing mode to Normal. Snap a window to an edge such as the Launcher or the Panel or screen edge. Resize the opposite side of the snapped edge. Terrible performance ensues.
= Fix =
A seemingly useless code block in the SnapWindow:
= Note =
I could not figure out what the real intent of the code block was for when resizing a window. It just didn't seem like it was supposed to do anything. As a matter of fact, when using the Default Resizing mode as Rectangle, this code was never touched, so it's not as if resizing a snapped window needed to do something special. At any rate, some pretty good testing of various resizing should be done to ensure there is no regressions by removing this code.
PASSED: Continuous integration, rev:3795 jenkins. qa.ubuntu. com/job/ compiz- team-compiz- 0.9.10- ci/15/ jenkins. qa.ubuntu. com/job/ compiz- team-compiz- 0.9.10- saucy-amd64- ci/15 jenkins. qa.ubuntu. com/job/ compiz- team-compiz- 0.9.10- saucy-armhf- ci/13 jenkins. qa.ubuntu. com/job/ compiz- team-compiz- 0.9.10- saucy-i386- ci/15
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ compiz- team-compiz- 0.9.10- ci/15/rebuild
http://