Merge lp://staging/~townsend/compiz/fix-auto-vp-switch-0.9.10 into lp://staging/compiz/0.9.10

Proposed by Christopher Townsend
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 3791
Merged at revision: 3791
Proposed branch: lp://staging/~townsend/compiz/fix-auto-vp-switch-0.9.10
Merge into: lp://staging/compiz/0.9.10
Diff against target: 55 lines (+21/-18)
1 file modified
plugins/wall/src/wall.cpp (+21/-18)
To merge this branch: bzr merge lp://staging/~townsend/compiz/fix-auto-vp-switch-0.9.10
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Brandon Schaefer (community) Approve
Review via email:

Commit message

Fix regression when selecting apps on a different viewport than the current one will no longer automatically switch the viewport.

Description of the change

= Issue =
A regression has occurred in which auto switching viewports no longer happens when using global Alt-Tab or selecting an app on the Launcher that is in a different viewport.

= Fix =
Be more smart about when to check for the optionGetAutoSwitchVpAndWindow () bool. Now only check in the code block that actually moves the window to a different viewport. This is only a half fix now for bug #1092323. The part of that bug to not switch viewports when the window is > 50% in a different viewport is still not fixed.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Confirmed fixes the issue, though we'll have to re-visit the other bug this was fixing :). This is a bigger thing to get fixed first.


review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches