Ubuntu
pkg-create-dbgsym package

Merge lp://staging/~tormodvolden/ubuntu/lucid/pkg-create-dbgsym/doublestrip into lp://staging/pkg-create-dbgsym

  1. Lucid (10.04)
  2. doublestrip
  3. Merge into ubuntu
Proposed by Tormod Volden
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://staging/~tormodvolden/ubuntu/lucid/pkg-create-dbgsym/doublestrip
Merge into: lp://staging/pkg-create-dbgsym
Diff against target: 28 lines (+10/-0)
2 files modified
debian/changelog (+8/-0)
pkg_create_dbgsym (+2/-0)
To merge this branch: bzr merge lp://staging/~tormodvolden/ubuntu/lucid/pkg-create-dbgsym/doublestrip
Reviewer Review Type Date Requested Status
Martin Pitt Needs Fixing
Review via email: mp+23880@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

This looks good, thanks! I'll add a test case first, and then merge this.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Ah, unfortunately this check isn't sufficient -- it will still cause a rebuild of the ddeb packages, which breaks their control fields (see failure of the test suite when this is merged). I'll figure this out, don't worry.

review: Needs Fixing
Revision history for this message
Tormod Volden (tormodvolden) wrote :

I think a good test case would be the xserver variant:
dh_strip --debug-package=something-dbg
dh_strip -s --remaining_packages

Revision history for this message
Tormod Volden (tormodvolden) wrote :

I haven't checked but I thought it would / think it should not build ddeb packages if it could not find a file to strip.

Revision history for this message
Martin Pitt (pitti) wrote :

Tormod Volden [2010-04-22 7:48 -0000]:
> I haven't checked but I thought it would / think it should not build
> ddeb packages if it could not find a file to strip.

Right, that's what I'm implementing now.

Revision history for this message
Martin Pitt (pitti) wrote :

Hm, I couldn't get it to work reliably with an approach like this. I now committed a check based on the existence of the ddeb in debian/files, which passes all tests and fixes this bug.

Unmerged revisions

177. By Tormod Volden

add changelog entry

176. By Tormod Volden

do not strip an already stripped file

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: