Merge lp://staging/~tony-badwolf/quickly/890318again into lp://staging/quickly
Proposed by
Tony Byrne
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~tony-badwolf/quickly/890318again |
| Merge into: | lp://staging/quickly |
| Diff against target: |
59 lines (+36/-1) 2 files modified
data/templates/ubuntu-application/project_root/python_lib/Builder.py (+2/-1) data/templates/ubuntu-application/project_root/tests/test_builder.py (+34/-0) |
| To merge this branch: | bzr merge lp://staging/~tony-badwolf/quickly/890318again |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Quickly Developers | Pending | ||
|
Review via email:
|
|||
Description of the change
Builder.py contains a function to change any widget name into a valid python name. This branch applies it to signal names also. Previous branch only checks for "-" in signal name (google "enumerate badness" to why this is inadequate) and does not check signals from "anonymous" top level windows.
To post a comment you must log in.
Unmerged revisions
- 641. By Tony Byrne <email address hidden> <email address hidden>
-
Convert both widget and signal name to a valid python variable name
fixes bug 890318 - 640. By Didier Roche-Tolomelli
-
Merge David's fix for fixing signal autoconnect does not work with
signal names which contain hypens (LP: #890318). Thanks! - 639. By Michael Terry
-
fix tests to pass with latest platform and quickly changes
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
