GTG

Merge lp://staging/~tomkadwill/gtg/delete-tag2 into lp://staging/~gtg/gtg/old-trunk

Proposed by Tom Kadwill
Status: Rejected
Rejected by: Izidor Matušov
Proposed branch: lp://staging/~tomkadwill/gtg/delete-tag2
Merge into: lp://staging/~gtg/gtg/old-trunk
Diff against target: 123 lines (+63/-2)
4 files modified
CHANGELOG (+1/-0)
GTG/gtk/browser/browser.py (+11/-2)
GTG/gtk/delete_dialog.py (+40/-0)
GTG/gtk/manager.py (+11/-0)
To merge this branch: bzr merge lp://staging/~tomkadwill/gtg/delete-tag2
Reviewer Review Type Date Requested Status
Izidor Matušov Disapprove
Review via email: mp+141682@code.staging.launchpad.net

Description of the change

Have fixed bug Bug #1044639

To post a comment you must log in.
Revision history for this message
Izidor Matušov (izidor) wrote :

Sorry for the late answer. When I run your code, I encounter the following traceback:

<code>
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/liblarch/processqueue.py", line 43, in process_queue
    func(*action[1:])
  File "/usr/lib/python2.7/dist-packages/liblarch/tree.py", line 269, in _modify_node
    self._callback('node-modified', node_id)
  File "/usr/lib/python2.7/dist-packages/liblarch/tree.py", line 78, in _callback
    func(node_id)
  File "/usr/lib/python2.7/dist-packages/liblarch/viewcount.py", line 85, in __modify
    displayed &= filt.is_displayed(nid)
  File "/usr/lib/python2.7/dist-packages/liblarch/filters_bank.py", line 42, in is_displayed
    value = self.func(task, parameters=self.dic)
  File "/home/izidor/projects/gtg/trunk/GTG/core/treefactory.py", line 146, in tag_filter
    return node.has_tags([tag])
  File "/home/izidor/projects/gtg/trunk/GTG/core/task.py", line 767, in has_tags
    toreturn = children_tag(tagname)
  File "/home/izidor/projects/gtg/trunk/GTG/core/task.py", line 751, in children_tag
    for tagc_name in tag.get_children():
AttributeError: 'NoneType' object has no attribute 'get_children'
</code>

At the moment, only one tag could be selected & removed. Please, change the text in the dialog to something like:

"Do you want to remove tag <b>[tag name]</b>?"

Make it different from the normal delete dialog.

Please, comment properly method

def ask_delete_tags(self, tags):

It took me quite a moment to understand how it work and why it works so. Please, use a loop instead of tags[0].

review: Needs Fixing (code,run)
Revision history for this message
Izidor Matušov (izidor) wrote :

Closing, no activity in year.

review: Disapprove

Unmerged revisions

1267. By Tom Kadwill

Fixed bug #1095451: can now delete tags

1266. By Tom Kadwill

Fixed bug #1095451: can now delete tags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: