Merge lp://staging/~tomdroid-dev/tomdroid/ContextMenu into lp://staging/~tomdroid-maintainers/tomdroid/main

Proposed by Edouard Richard
Status: Merged
Merged at revision: 223
Proposed branch: lp://staging/~tomdroid-dev/tomdroid/ContextMenu
Merge into: lp://staging/~tomdroid-maintainers/tomdroid/main
Diff against target: 183 lines (+93/-2)
5 files modified
res/menu/main_longclick.xml (+8/-0)
res/values/strings.xml (+2/-0)
src/org/tomdroid/ui/Tomdroid.java (+38/-1)
src/org/tomdroid/util/NoteContentBuilder.java (+6/-1)
src/org/tomdroid/util/Send.java (+39/-0)
To merge this branch: bzr merge lp://staging/~tomdroid-dev/tomdroid/ContextMenu
Reviewer Review Type Date Requested Status
Benoit Garret Needs Information
Olivier Bilodeau Pending
Review via email: mp+23840@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Benoit Garret (benoit.garret) wrote :

Olivier, Rodja, are you okay with this feature? If I understood correctly, it'll add a long press menu with the ability to send the note by email, sms, etc.

I would remove the delete note feature, as it really belongs to another branch, but the send feature is small enough to be easy to merge and imho useful. I'd also like to add the send item on the menu show when viewing the note.

review: Needs Information
Revision history for this message
Benoit Garret (benoit.garret) wrote :

Merged, without the delete feature.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches