Merge lp://staging/~tobias-klevenz/terminator/fix-transparent-seprators into lp://staging/terminator/gtk3
Proposed by
Tobias Klevenz
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~tobias-klevenz/terminator/fix-transparent-seprators |
| Merge into: | lp://staging/terminator/gtk3 |
| Diff against target: |
27 lines (+8/-2) 1 file modified
terminatorlib/terminator.py (+8/-2) |
| To merge this branch: | bzr merge lp://staging/~tobias-klevenz/terminator/fix-transparent-seprators |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bryce Harrington | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Found an issue with various newer Gtk3 themes on Ubuntu 17.10 where terminators pane separators appeared completely transparent.
Affected themes:
https:/
https:/
Additionally the handle_size set in the config was ignored for all themes, using min-width and min-height on paned separator fixed this.
To post a comment you must log in.
Unmerged revisions
- 1788. By Tobias Klevenz
-
fix transparent pane separator for newer Gtk3 themes like Materia and Pop
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Being able to resize the separator width again is a nice improvement, and works well.
This does fix the transparency issue, although on my system I noticed this added a stipple pattern to the separator background, which seems to create drawing glitches with its black border. Turning off the border seems to give more pleasant results with this fix:
Maybe there's a better way to address this, but with that fixed one way or another, +1 approve.
Test case I used:
$ cat > /tmp/config <<EOF
[layouts]
[[test]]
[[[window0]]]
parent = ""
type = Window
[[[child0]]]
parent = window0
type = HPaned
[[[child1]]]
parent = child0
type = Terminal
[[[child2]]]
parent = child0
type = Terminal
EOF
$ terminator --no-dbus --config /tmp/config --layout test