Merge lp://staging/~tkluck/ubuntu/precise/gnome-shell/lp883443 into lp://staging/ubuntu/precise/gnome-shell
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~tkluck/ubuntu/precise/gnome-shell/lp883443 |
| Merge into: | lp://staging/ubuntu/precise/gnome-shell |
| Diff against target: |
100 lines (+46/-3) 5 files modified
.pc/applied-patches (+1/-0) debian/changelog (+10/-0) debian/patches/12-let-transient-critical-notifications-expire.patch (+31/-0) debian/patches/series (+1/-0) js/ui/messageTray.js (+3/-3) |
| To merge this branch: | bzr merge lp://staging/~tkluck/ubuntu/precise/gnome-shell/lp883443 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Disapprove | ||
| Jeremy Bícha | Pending | ||
| Ubuntu branches | Pending | ||
|
Review via email:
|
|||
Description of the change
This fixes #883443. Testcase:
send a critical, transient message:
$ notify-send -u critical -h int:transient:1 "blabla"
it will never disappear in gnome-shell. In ubuntu-patched network-manager, a network disconnect leads to such a message. It will even reappear after suspend/hibernate etc (even if the networking situation has changed any number of times in between), which is very confusing. The patch makes sure that critical, transient messages behave as if they are urgency=normal messages. They will show for 4 seconds and then disappear.
I am not aware of any other critical, transient messages, and it seems contrary to the spirit of messaging in gnome-shell. So this should probably be patched on the ubuntu side.
| Luke Yelavich (themuso) wrote | # |
Unmerged revisions
- 49. By Timo Kluck
-
- Treat transient, critical notifications the same as non-critical
ones (notably the ubuntu-specific one that says "network disconnected,
you are now offline") Closes: #883443
*
Jeremy, since you work on gnome-shell a fair bit, could you please have a look at this?