Ubuntu
grub-installer package

Merge lp://staging/~tj/ubuntu/trusty/grub-installer/lp1354730 into lp://staging/ubuntu/trusty/grub-installer

  1. Trusty (14.04)
  2. lp1354730
  3. Merge into trusty
Proposed by TJ
Status: Rejected
Rejected by: Mathieu Trudel-Lapierre
Proposed branch: lp://staging/~tj/ubuntu/trusty/grub-installer/lp1354730
Merge into: lp://staging/ubuntu/trusty/grub-installer
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
grub-installer (+1/-1)
To merge this branch: bzr merge lp://staging/~tj/ubuntu/trusty/grub-installer/lp1354730
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Disapprove
Colin Watson (community) Needs Fixing
Review via email: mp+230222@code.staging.launchpad.net

Description of the change

Fix installer failure due to grub-probe returning more than one device in the case of BTRS multi-disk RAID volumes.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

12:51 <seb128> cjwatson, hey, do you think you could review https://code.launchpad.net/~tj/ubuntu/trusty/grub-installer/lp1354730/+merge/230222 or maybe suggest somebody who could? that's a one line and is in the sponsoring queue since august
12:52 <cjwatson> seb128: It needs to go into a branch based on lp:~ubuntu-core-dev/grub-installer/ubuntu (except branched for trusty), rather than using the unused UDD branch. But I'm not doing d-i stuff now in general; maybe slangasek can suggest somebody.
12:52 <cjwatson> (Oh and it should use head -n1 not head -1 on general principles)

Revision history for this message
Colin Watson (cjwatson) wrote :

Oh, also, the version number will need to be 1.78ubuntu20.1 rather than 1.78ubuntu21. You can see from https://launchpad.net/ubuntu/+source/grub-installer/+publishinghistory that the latter was already used in utopic.

review: Needs Fixing
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

It looks like this was in fact breaking grub-installer in some cases in vivid; rejecting. Details are on the bug report.

review: Disapprove

Unmerged revisions

118. By TJ

grub_probe(): return a single line in BTRFS multi-disk RAID configurations

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: