Merge lp://staging/~tj/ubuntu/trusty/alsa-utils/lp1269731 into lp://staging/ubuntu/trusty/alsa-utils
Proposed by
TJ
Status: | Rejected |
---|---|
Rejected by: | Luke Yelavich |
Proposed branch: | lp://staging/~tj/ubuntu/trusty/alsa-utils/lp1269731 |
Merge into: | lp://staging/ubuntu/trusty/alsa-utils |
Diff against target: |
195 lines (+113/-3) 10 files modified
.pc/applied-patches (+1/-0) .pc/lp1269731_incorrect_shell_constructions_cause_upstart_kernel_panic.diff/debian/alsa-restore.upstart (+18/-0) .pc/lp1269731_incorrect_shell_constructions_cause_upstart_kernel_panic.diff/debian/alsa-state.upstart (+22/-0) .pc/lp1269731_incorrect_shell_constructions_cause_upstart_kernel_panic.diff/debian/alsa-store.upstart (+18/-0) debian/alsa-restore.upstart (+1/-1) debian/alsa-state.upstart (+1/-1) debian/alsa-store.upstart (+1/-1) debian/changelog (+7/-0) debian/patches/lp1269731_incorrect_shell_constructions_cause_upstart_kernel_panic.diff (+43/-0) debian/patches/series (+1/-0) |
To merge this branch: | bzr merge lp://staging/~tj/ubuntu/trusty/alsa-utils/lp1269731 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu branches | Pending | ||
Review via email: mp+202014@code.staging.launchpad.net |
Description of the change
Critical fix for kernel panic in upstart init deamon caused by incorrect shell constructions in upstart conf files
To post a comment you must log in.
Thanks for your work, however ou don't patch files in the debian directory. You edit them directly.
Secondly, as per the bug, the original shell code is syntactically correct, and I forgot to add an env declaration to the ALSACTLHOME variable, whichi I already have a fix for, and am about to upload.
Thanks again.