Switchboard

Merge lp://staging/~tintou/switchboard/parent-fallback into lp://staging/~elementary-pantheon/switchboard/switchboard

  1. parent-fallback
  2. Merge into switchboard
Proposed by Corentin Noël
Status: Merged
Approved by: Danielle Foré
Approved revision: 714
Merged at revision: 716
Proposed branch: lp://staging/~tintou/switchboard/parent-fallback
Merge into: lp://staging/~elementary-pantheon/switchboard/switchboard
Diff against target: 75 lines (+36/-22)
1 file modified
src/Switchboard.vala (+36/-22)
To merge this branch: bzr merge lp://staging/~tintou/switchboard/parent-fallback
Reviewer Review Type Date Requested Status
Adam Bieńkowski (community) code Approve
Review via email: mp+313057@code.staging.launchpad.net

Commit message

Implement fallback to "parent" setting path

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can confirm that this works as expected with full fallbacks :)

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Looks good to me except few things:
* I don't really think it can be somehow done, but load_setting_path () always gets the plugs manager instance, which is not really great when path has more components. Perhaps, just passing PlugsManager to the method?

* If statement on diff line 64 should have braces, since we changed that in elementary code style guidelines.

Otherwise, looks okay.

review: Needs Fixing (code)
lp://staging/~tintou/switchboard/parent-fallback updated
714. By Corentin Noël

Implement fallback to "parent" setting path

Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Looking great for me now, thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: