Switchboard Network Plug

Merge lp://staging/~tintou/switchboard-plug-networking/proxy-update into lp://staging/~elementary-pantheon/switchboard-plug-networking/trunk

  1. proxy-update
  2. Merge into trunk
Proposed by Corentin Noël
Status: Merged
Approved by: Adam Bieńkowski
Approved revision: 324
Merged at revision: 325
Proposed branch: lp://staging/~tintou/switchboard-plug-networking/proxy-update
Merge into: lp://staging/~elementary-pantheon/switchboard-plug-networking/trunk
Diff against target: 425 lines (+222/-180)
1 file modified
src/Widgets/Proxy/ProxyConfigurationPage.vala (+222/-180)
To merge this branch: bzr merge lp://staging/~tintou/switchboard-plug-networking/proxy-update
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Adam Bieńkowski (community) code / testing Approve
Review via email: mp+309856@code.staging.launchpad.net

Commit message

* Update proxy layout
* Fix for not showing the current proxy configuration

To post a comment you must log in.
Revision history for this message
Adam Bieńkowski (donadigo) wrote :

Thank you for taking time to make this! It looks great for me, only a couple small code style issues which doesn't get into the way of approving. I would also like this to be reviewed by Daniel just to make sure the UI is looking okay for him.

review: Approve (code / testing)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Yeah we could probably come up with some things to streamline in the future, but I think it looks fine :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches