Slingshot

Merge lp://staging/~tintou/slingshot/no-pixbuf into lp://staging/~elementary-pantheon/slingshot/trunk

  1. no-pixbuf
  2. Merge into trunk
Proposed by Corentin Noël
Status: Merged
Approved by: Cody Garver
Approved revision: 617
Merged at revision: 617
Proposed branch: lp://staging/~tintou/slingshot/no-pixbuf
Merge into: lp://staging/~elementary-pantheon/slingshot/trunk
Diff against target: 400 lines (+65/-200)
3 files modified
src/Backend/App.vala (+24/-168)
src/Widgets/AppEntry.vala (+37/-30)
src/Widgets/SearchItem.vala (+4/-2)
To merge this branch: bzr merge lp://staging/~tintou/slingshot/no-pixbuf
Reviewer Review Type Date Requested Status
Danielle Foré ux Approve
elementary Pantheon team code Pending
Review via email: mp+281234@code.staging.launchpad.net

Commit message

Use GIcon instead of Pixbuf loaded at startup

Description of the change

Use GIcon instead of Pixbuf loaded at startup

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I can confirm that this branch works as expected and that icons now render properly for HiDPI

review: Approve (ux)
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

should "gtk_icon_theme_lookup_by_gicon_for_scale" be used?

Revision history for this message
Corentin Noël (tintou) wrote :

I depends of the behavior we want, do we want to show the fallback icon if there is no icon of the size we want or do we want to show the original icon but scaled to the size we request ?

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Nevermind, just saying the *_for_scale are meant to be used for hidpi support, but you are not using its result anyway.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches