Files

Merge lp://staging/~tintou/pantheon-files/plugin-fix into lp://staging/~elementary-apps/pantheon-files/trunk

  1. plugin-fix
  2. Merge into trunk
Proposed by Corentin Noël
Status: Superseded
Proposed branch: lp://staging/~tintou/pantheon-files/plugin-fix
Merge into: lp://staging/~elementary-apps/pantheon-files/trunk
Diff against target: 413 lines (+135/-146)
2 files modified
filechooser-module/FileChooserDialog.vala (+129/-141)
filechooser-module/Plugin.vala (+6/-5)
To merge this branch: bzr merge lp://staging/~tintou/pantheon-files/plugin-fix
Reviewer Review Type Date Requested Status
Jeremy Wootten Needs Fixing
Adam Bieńkowski Pending
Review via email: mp+291467@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-12-08.

This proposal has been superseded by a proposal from 2016-04-12.

Commit message

Update Gtk.FileChooserDialog plugin for Loki

Description of the change

This change is required because the Gtk.FileChooserDialog has changed a lot since the Gtk version in Freya

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote : Posted in a previous version of this proposal

I can confirm that this behaves as expected on Loki with Gtk 3.19

Revision history for this message
Jeremy Wootten (jeremywootten) wrote : Posted in a previous version of this proposal

The size and position of the Cancel and Save buttons looks odd when using Gtk 3.14

review: Needs Fixing
Revision history for this message
Corentin Noël (tintou) wrote : Posted in a previous version of this proposal

Yeah I'll have to use conditional compilation to have it working as before in pre-3.18 versions

Revision history for this message
Jeremy Wootten (jeremywootten) wrote : Posted in a previous version of this proposal

Or bump the minimum Gtk version - but I guess we do not want to do that yet.

Revision history for this message
Adam Bieńkowski (donadigo) wrote : Posted in a previous version of this proposal

The branch looks good but, as far as I can see there's one issue:
back and forward buttons don't work as expected, sometimes going back and sometimes not. Needs fixing for me.

review: Needs Fixing
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Fixes duplicate pathbar but ....

Regression: History buttons no longer function (in open file mode)
Regression: Scratch crashes when saving file

review: Needs Fixing
lp://staging/~tintou/pantheon-files/plugin-fix updated
2108. By Corentin Noël

Fixed the Filechooser for Gtk 3.18

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: