AppCenter

Merge lp://staging/~tintou/appcenter/optimizations into lp://staging/~ricotz/appcenter/optimizations

  1. optimizations
  2. Merge into optimizations
Proposed by Corentin Noël
Status: Needs review
Proposed branch: lp://staging/~tintou/appcenter/optimizations
Merge into: lp://staging/~ricotz/appcenter/optimizations
Diff against target: 36 lines (+8/-9)
1 file modified
src/Core/Package.vala (+8/-9)
To merge this branch: bzr merge lp://staging/~tintou/appcenter/optimizations
Reviewer Review Type Date Requested Status
Rico Tzschichholz Pending
Review via email: mp+309464@code.staging.launchpad.net

Description of the change

I think it's better like this, tell me if it's a bad idea

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

The boolean variable is not meant to catch race-conditions with threads, but simply the case if there is no matching package found or an error occurred, which the API suggests could happen.

If this function gets actually called in a multi-threaded environment adding a lock would make sense though.

Reply
Revision history for this message
Zisu Andrei (matzipan) wrote :

Rejecting as per Rico's comment.

Reply
Revision history for this message
Zisu Andrei (matzipan) wrote :

Whoops. Appears I can't do that myself. Rico?

Reply

Unmerged revisions

331. By Corentin Noël

Use existing variables.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches