Online Accounts: Sign-on daemon

Merge lp://staging/~timo-jyrinki/signon/drop_quilt_usage into lp://staging/signon

  1. drop_quilt_usage
  2. Merge into trunk
Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 613
Merged at revision: 612
Proposed branch: lp://staging/~timo-jyrinki/signon/drop_quilt_usage
Merge into: lp://staging/signon
Diff against target: 28 lines (+1/-3)
3 files modified
debian/control (+0/-1)
debian/rules (+1/-1)
debian/source/format (+0/-1)
To merge this branch: bzr merge lp://staging/~timo-jyrinki/signon/drop_quilt_usage
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Approve
Alberto Mardegan (community) Approve
Timo Jyrinki (community) Approve
Review via email: mp+201733@code.staging.launchpad.net

Commit message

Drop quilt usage as recommended for daily release packages

Description of the change

Drop quilt usage as recommended for daily release packages - https://wiki.ubuntu.com/DailyRelease/InlinePackaging

It seems this is not strictly needed for cu2d, but I believe this is the reason that prevents signon from auto-building using LP recipe: https://code.launchpad.net/~canonical-qt5-edgers/+archive/qt5-beta2/+recipebuild/629498 - this makes it slower to get builds against Qt 5.2 done, instead of automatical.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:612
http://jenkins.qa.ubuntu.com/job/signon-ci/49/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-trusty-amd64-ci/9/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-trusty-armhf-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/signon-ci/49/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:613
http://jenkins.qa.ubuntu.com/job/signon-ci/50/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/signon-trusty-amd64-ci/10/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/signon-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/signon-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/signon-ci/50/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Please try again, Jenkins, in case those test failures were random flaky tests.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This is not hugely important, and I'm not even sure if solves the recipe problem, but if quilt is not needed it's probably better dropped.

Revision history for this message
Alberto Mardegan (mardy) wrote :

The jenkins failure is a flacky test (probably build machine being über-slow).
The change is fone to me, I'd just like to get Ken's thoughts on it as well.

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

This is fine, that was leftover from when we applied patches for only armhf.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Top-approving to get jenkins re-evaluation (and merge if ok).

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: