gnome-control-center

Merge lp://staging/~timchen119/gnome-control-center/gnome-control-center.precise.lp1244065 into lp://staging/~ubuntu-desktop/gnome-control-center/precise

  1. gnome-control-center.precise.lp1244065
  2. Merge into precise
Proposed by Tim Chen
Status: Merged
Merged at revision: 475
Proposed branch: lp://staging/~timchen119/gnome-control-center/gnome-control-center.precise.lp1244065
Merge into: lp://staging/~ubuntu-desktop/gnome-control-center/precise
Diff against target: 61 lines (+41/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/more-power-suspend-options.patch (+32/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~timchen119/gnome-control-center/gnome-control-center.precise.lp1244065
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+193183@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-10-24.

Description of the change

* Add additional options to the power option system sleep settings menu.
   Add 20 minutes and 2 hours options to give the user more fine-grained
   controls. (LP: #1244065)

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

Thank you for the work there, some notes about your work:

- could you edit the patch to add the info you added to the trunk version (bug reference, description, etc)

- the bug report needs SRU impact/test case/regression potential (see https://wiki.ubuntu.com/StableReleaseUpdates for details)

- could you ask the SRU team (https://launchpad.net/~ubuntu-sru/+members#active) if that's fine to add those options in a stable update?

- you are targetting the wrong vcs, lp:~ubuntu-desktop/gnome-control-center/precise is the packaging branch for the LTS

Otherwise the changes look fine for an upload

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

oh, also having a changelog entry would be useful

Revision history for this message
Tim Chen (timchen119) wrote :

@Seb

Thanks the help and I've modified the patch and resubmit the proposal, please help to review it and I'll ask SRU team about this too. Thanks a lot for the great support.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The patch looks good, I'm going to merge/upload it once the SRU team acks that the change is ok for a SRU

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

did you ask the SRU team about that one?

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've merged and uploaded so get that moving, the SRU team needs to be convinced next

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: