Merge ~till-kamppeter/network-manager:master into network-manager:master

Proposed by Till Kamppeter
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: ~till-kamppeter/network-manager:master
Merge into: network-manager:master
Diff against target: 146 lines (+124/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/WiFi-detect-FT-support-per-interface-and-avoid-enabling-it.patch (+116/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Iain Lane (community) Disapprove
Review via email: mp+372162@code.staging.launchpad.net

Commit message

Backport detecting Wi-Fi FT support per interface, release as 1.20.0-1ubuntu2

See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/2f8a4e90f0f

Description of the change

This is a backport of the upstream change to not prefer FT-PSK when it is only supported by supplicant but not by the Wi-Fi interface or driver.

From upstream:

Previously we only cared whether supplicant is build with support for
FT. In that case we would pass FT-PSK to supplicant, like

  Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'

Supplicant would then always try FT with preference, regardless whether
the interface/driver support it. That results in a failure to associate, if
the driver does not support it.

  NetworkManager[1356]: <info> [1566296144.9940] Config: added 'key_mgmt' value 'WPA-PSK WPA-PSK-SHA256 FT-PSK'
  ...
  wpa_supplicant[1348]: wlan0: WPA: AP key_mgmt 0x42 network profile key_mgmt 0x142; available key_mgmt 0x42
  wpa_supplicant[1348]: wlan0: WPA: using KEY_MGMT FT/PSK
  ...
  wpa_supplicant[1348]: * akm=0xfac04
  ...
  kernel: ERROR @wl_set_key_mgmt :
  kernel: invalid cipher group (1027076)

Since we pass a list of acceptable "key_mgmt" options to supplicant,
FT-PSK should not be used when supplicant knows it's not supported.
That is a supplicant bug.

Regardless, work around it by checking the per-interface capability, and
avoid it if support is apparently not present.

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

just told Till this on IRC: there is a new upstream version containing this fix, which is available in Debian too - we should merge it too I think

review: Disapprove
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Till, it looks good but as Laney said it's superseeded by the new version and I'm doing that merge now, so closing this one

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: