telephony-service

Merge lp://staging/~tiagosh/telephony-service/use-libphonenumber into lp://staging/telephony-service

  1. use-libphonenumber
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1115
Merged at revision: 1110
Proposed branch: lp://staging/~tiagosh/telephony-service/use-libphonenumber
Merge into: lp://staging/telephony-service
Diff against target: 1022 lines (+254/-371)
19 files modified
Ubuntu/Telephony/contactwatcher.cpp (+1/-1)
debian/copyright (+0/-17)
indicator/textchannelobserver.cpp (+1/-1)
libtelephonyservice/CMakeLists.txt (+2/-0)
libtelephonyservice/multimediaaccountentry.cpp (+1/-1)
libtelephonyservice/ofonoaccountentry.cpp (+27/-1)
libtelephonyservice/ofonoaccountentry.h (+5/-0)
libtelephonyservice/phonenumberutils.h (+0/-303)
libtelephonyservice/phoneutils.cpp (+100/-24)
libtelephonyservice/phoneutils.h (+20/-2)
tests/common/mock/MockConnection.xml (+6/-0)
tests/common/mock/connection.cpp (+7/-0)
tests/common/mock/connection.h (+2/-0)
tests/common/mock/emergencymodeiface.cpp (+28/-1)
tests/common/mock/emergencymodeiface.h (+12/-0)
tests/common/mock/mockconnectiondbus.cpp (+6/-0)
tests/common/mock/mockconnectiondbus.h (+1/-0)
tests/libtelephonyservice/OfonoAccountEntryTest.cpp (+18/-0)
tests/libtelephonyservice/PhoneUtilsTest.cpp (+17/-20)
To merge this branch: bzr merge lp://staging/~tiagosh/telephony-service/use-libphonenumber
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+264906@code.staging.launchpad.net

Commit message

Use libphonenumber for phone number validation, normalization and comparison.

Description of the change

Use libphonenumber for phone number validation, normalization and comparison.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1102
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/499/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/171/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/167/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/167/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/499/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1103. By Tiago Salem Herrmann

reenable tests

1104. By Tiago Salem Herrmann

fix copyright header

1105. By Tiago Salem Herrmann

revert po changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1105
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/500/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/172/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/168/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/168/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/500/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1106. By Tiago Salem Herrmann

Provide a fallback to country code if none is provided

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1106
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/502/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/174
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/170
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/170/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/170

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/502/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1107. By Tiago Salem Herrmann

Read countryCode() from ofono

1108. By Tiago Salem Herrmann

Add code to fallback

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1108
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/503/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/175
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/171
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/171/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/171

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/503/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1109. By Tiago Salem Herrmann

Use IsEmergencyNumber() instead of ConnectsToEmergencyNumber()

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1109
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/504/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/172
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/172/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/172

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/504/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1110. By Tiago Salem Herrmann

Change comparePhoneNumbers() to return PhoneUtils::PhoneNumberMatchType

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1110
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/507/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/179
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/175
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/175/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/175

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/507/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1111. By Tiago Salem Herrmann

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1111
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/509/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/181
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/177
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/177/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/177

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/509/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1112. By Tiago Salem Herrmann

Only use libphonenumber if both numbers have more than 7 digits

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1112
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/514/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/186
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/182
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/182/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/182

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/514/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1113. By Tiago Salem Herrmann

fix build with libphonenumber >= 7

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1113
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/520/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/192
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/188
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/188/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/188

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/520/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Just one request, other than that the code looks good!

review: Needs Fixing
lp://staging/~tiagosh/telephony-service/use-libphonenumber updated
1114. By Tiago Salem Herrmann

add test for numbers with slash

1115. By Tiago Salem Herrmann

add test for phones with slashes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1115
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/525/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/197
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/193
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/193/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/193

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/525/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches