Merge lp://staging/~tiagosh/telephony-service/fix-voicemail-indicator2 into lp://staging/telephony-service

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: no longer in the source branch.
Merged at revision: 855
Proposed branch: lp://staging/~tiagosh/telephony-service/fix-voicemail-indicator2
Merge into: lp://staging/telephony-service
Diff against target: 97 lines (+44/-9)
2 files modified
libtelephonyservice/callmanager.cpp (+43/-9)
libtelephonyservice/callmanager.h (+1/-0)
To merge this branch: bzr merge lp://staging/~tiagosh/telephony-service/fix-voicemail-indicator2
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+227991@code.staging.launchpad.net

Commit message

Listen for VoicemailNumberChanged() signal

Description of the change

Listen for VoicemailNumberChanged() signal

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/telepathy-ofono/fix-voicemail-indicator/+merge/227990

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telephony-service) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve
854. By Tiago Salem Herrmann

Use correct label for blocked and private numbers on messaging-menu. Fixes: 1340386, 1347708
Approved by: Gustavo Pichorim Boiko

855. By Tiago Salem Herrmann

Listen for VoicemailNumberChanged() signal Fixes: 1347085

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches