Merge lp://staging/~tiagosh/telephony-service/fix-1398427 into lp://staging/telephony-service
| Status: | Merged |
|---|---|
| Approved by: | Gustavo Pichorim Boiko |
| Approved revision: | 996 |
| Merged at revision: | 994 |
| Proposed branch: | lp://staging/~tiagosh/telephony-service/fix-1398427 |
| Merge into: | lp://staging/telephony-service |
| Diff against target: |
299 lines (+106/-8) 10 files modified
approver/Approver.xml (+7/-0) approver/approver.cpp (+53/-2) approver/approver.h (+4/-0) approver/approverdbus.cpp (+6/-1) approver/approverdbus.h (+5/-1) approver/main.cpp (+4/-4) libtelephonyservice/callmanager.cpp (+11/-0) libtelephonyservice/callmanager.h (+1/-0) libtelephonyservice/telepathyhelper.cpp (+13/-0) libtelephonyservice/telepathyhelper.h (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~tiagosh/telephony-service/fix-1398427 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Zanetti (community) | Approve | ||
| Gustavo Pichorim Boiko (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Michał Sawicz | Approve | ||
|
Review via email:
|
|||
Commit message
Expose HandleMediaKey(bool doubleClick) to DBus.
Description of the change
Expose HandleMediaKey(bool doubleClick) to DBus.
This is going to be called by unity8.
--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
N/A
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
| PS Jenkins bot (ps-jenkins) wrote | # |
| Tiago Salem Herrmann (tiagosh) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Michał Sawicz (saviq) | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Michael Zanetti (mzanetti) wrote | # |
Hey, do you think it'd make sense for you to return true/false depending on whether you accepted (consumed/reacted to) the event? We could fall back to other consumers then.