ofono-qt

Merge lp://staging/~tiagosh/ofono-qt/multiparty into lp://staging/~phablet-team/ofono-qt/trunk

  1. multiparty
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Approved
Approved by: Gustavo Pichorim Boiko
Approved revision: 18
Proposed branch: lp://staging/~tiagosh/ofono-qt/multiparty
Merge into: lp://staging/~phablet-team/ofono-qt/trunk
Diff against target: 45 lines (+12/-6)
2 files modified
lib/ofonovoicecallmanager.cpp (+11/-5)
lib/ofonovoicecallmanager.h (+1/-1)
To merge this branch: bzr merge lp://staging/~tiagosh/ofono-qt/multiparty
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+210294@code.staging.launchpad.net

Commit message

Make createMultiparty() call synchronous.

Description of the change

Make createMultiparty() call synchronous.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:18
http://jenkins.qa.ubuntu.com/job/ofono-qt-ci/2/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ofono-qt-trusty-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ofono-qt-trusty-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/ofono-qt-trusty-armhf-ci/2/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ofono-qt-trusty-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ofono-qt-ci/2/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/ofono-qt) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
No UI changes

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
No changes

Reply
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator? Yes
Did CI run pass? If not, please explain why. Yes
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut? Yes

Code looks good and works as expected!

review: Approve
Reply

Unmerged revisions

18. By Tiago Salem Herrmann

make createMultiparty() call synchronous

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches