messaging-app

Merge lp://staging/~tiagosh/messaging-app/no-nbsp-in-bubbles into lp://staging/messaging-app

  1. no-nbsp-in-bubbles
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Needs review
Proposed branch: lp://staging/~tiagosh/messaging-app/no-nbsp-in-bubbles
Merge into: lp://staging/messaging-app
Diff against target: 48 lines (+13/-9)
1 file modified
src/qml/MessageBubble.qml (+13/-9)
To merge this branch: bzr merge lp://staging/~tiagosh/messaging-app/no-nbsp-in-bubbles
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Sebastien Bacher Needs Fixing
Review via email: mp+273467@code.staging.launchpad.net

Commit message

Use   to ensure lines will be properly broken in word boundaries.

Description of the change

Use   to ensure lines will be properly broken in word boundaries.

To post a comment you must log in.
lp://staging/~tiagosh/messaging-app/no-nbsp-in-bubbles updated
446. By Tiago Salem Herrmann

Use Text.AutoText and don't try replacing spaces

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:445
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/660/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4509
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/173
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3662
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4506
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4506/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23967

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/660/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:446
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/661/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4514
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/174
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3663
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4511
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4511/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23969

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/661/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks but that restore bug #1467347 (leading spaces being removed) which we got several users to report because it destroys carreful manual formating of texts...

review: Needs Fixing
Reply
lp://staging/~tiagosh/messaging-app/no-nbsp-in-bubbles updated
447. By Tiago Salem Herrmann

only replace \n by <br> if the plain text was turned into html

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:447
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/662/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4518
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/175
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3667
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4515
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4515/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23988

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/662/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:447
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/10/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/664/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/664/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

447. By Tiago Salem Herrmann

only replace \n by <br> if the plain text was turned into html

446. By Tiago Salem Herrmann

Use Text.AutoText and don't try replacing spaces

445. By Tiago Salem Herrmann

Use ensp to ensure lines will be broken in word boundaries

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches