Merge lp://staging/~tiagosh/messaging-app/grouped_threads into lp://staging/messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 443
Merged at revision: 451
Proposed branch: lp://staging/~tiagosh/messaging-app/grouped_threads
Merge into: lp://staging/messaging-app
Prerequisite: lp://staging/~tiagosh/messaging-app/updateFilters-binding
Diff against target: 207 lines (+59/-26)
6 files modified
src/qml/MMSDelegate.qml (+4/-10)
src/qml/MainPage.qml (+8/-3)
src/qml/Messages.qml (+25/-3)
src/qml/MessagesListView.qml (+1/-0)
src/qml/ThreadDelegate.qml (+13/-1)
src/qml/messaging-app.qml (+8/-9)
To merge this branch: bzr merge lp://staging/~tiagosh/messaging-app/grouped_threads
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+271533@code.staging.launchpad.net

Commit message

Use groupedThreads role from the model to generate history event filters.

Description of the change

Use groupedThreads role from the model to generate history event filters.

To post a comment you must log in.
431. By Tiago Salem Herrmann

Fix message search

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
432. By Tiago Salem Herrmann

Fix delete from header action

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
433. By Tiago Salem Herrmann

revert back to use grouped model

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
434. By Tiago Salem Herrmann

merge trunk

435. By Tiago Salem Herrmann

merge parent branch

436. By Tiago Salem Herrmann

fix empty header

437. By Tiago Salem Herrmann

use identifier only

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
438. By Tiago Salem Herrmann

add thread to filter if not there yet

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
439. By Tiago Salem Herrmann

Fix thread removal and messaging-menu acknowledgement

440. By Tiago Salem Herrmann

Use contact alias coming from history service

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
441. By Tiago Salem Herrmann

check for unknown contacts

442. By Tiago Salem Herrmann

use same string as other components

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
443. By Tiago Salem Herrmann

use string list as participants argument

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches