history-service

Merge lp://staging/~tiagosh/history-service/set-max-count into lp://staging/history-service

  1. set-max-count
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 214
Merged at revision: 212
Proposed branch: lp://staging/~tiagosh/history-service/set-max-count
Merge into: lp://staging/history-service
Prerequisite: lp://staging/~boiko/history-service/store_normalized_phone_numbers
Diff against target: 45 lines (+9/-5)
1 file modified
historyprivate/contactmatcher.cpp (+9/-5)
To merge this branch: bzr merge lp://staging/~tiagosh/history-service/set-max-count
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+270719@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-09-10.

Commit message

- Set max count hint
- Don't use fallback to tel to avoid queries to the address-book-service with null filters

Description of the change

- Set max count hint
- Don't use fallback to tel to avoid queries to the address-book-service with null filters

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:213
http://jenkins.qa.ubuntu.com/job/history-service-ci/225/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/63
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/63

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/225/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/history-service/set-max-count updated
214. By Tiago Salem Herrmann

merge parent branch

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:214
http://jenkins.qa.ubuntu.com/job/history-service-ci/289/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/127
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/128
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/128/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/127

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/289/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches