history-service

Merge lp://staging/~tiagosh/history-service/manually_add_self_contact_to_participants into lp://staging/history-service

  1. manually_add_self_contact_to_participants
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 200
Merged at revision: 204
Proposed branch: lp://staging/~tiagosh/history-service/manually_add_self_contact_to_participants
Merge into: lp://staging/history-service
Prerequisite: lp://staging/~tiagosh/history-service/generate-eventIds
Diff against target: 80 lines (+18/-13)
2 files modified
daemon/historydaemon.cpp (+17/-13)
daemon/historydaemon.h (+1/-0)
To merge this branch: bzr merge lp://staging/~tiagosh/history-service/manually_add_self_contact_to_participants
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+265071@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-07-13.

Commit message

Manually add self id to participants list if needed.

Description of the change

Manually add self id to participants list if needed.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:198
http://jenkins.qa.ubuntu.com/job/history-service-ci/201/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/39/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/39/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/201/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote : Posted in a previous version of this proposal

73 + QStringList participantsFromChannel(const Tp::TextChannelPtr &textChannel);

Can you make it either const or static? I think static would be better for this case

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/history-service-ci/202/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/41/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/40/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/202/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote : Posted in a previous version of this proposal

> 73 + QStringList participantsFromChannel(const Tp::TextChannelPtr
> &textChannel);
>
> Can you make it either const or static? I think static would be better for
> this case

Done

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:200
http://jenkins.qa.ubuntu.com/job/history-service-ci/204/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/42
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/43
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/43/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/42

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/204/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches