history-service

Merge lp://staging/~tiagosh/history-service/information-messageType into lp://staging/history-service

  1. information-messageType
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 179
Merged at revision: 173
Proposed branch: lp://staging/~tiagosh/history-service/information-messageType
Merge into: lp://staging/history-service
Diff against target: 298 lines (+132/-14)
9 files modified
Ubuntu/History/historymodel.cpp (+25/-0)
Ubuntu/History/historymodel.h (+11/-0)
daemon/historydaemon.cpp (+5/-5)
plugins/sqlite/schema/v9.sql (+81/-0)
src/event.cpp (+1/-1)
src/tests/TextEventTest.cpp (+4/-4)
src/tests/VoiceEventTest.cpp (+1/-1)
src/textevent.cpp (+1/-1)
src/types.h (+3/-2)
To merge this branch: bzr merge lp://staging/~tiagosh/history-service/information-messageType
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+235859@code.staging.launchpad.net

Commit message

Add support for a new message Type: MessageTypeInformation

Description of the change

Add support for a new message Type: MessageTypeInformation

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/history-service) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:178
http://jenkins.qa.ubuntu.com/job/history-service-ci/156/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-utopic-amd64-ci/51/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-utopic-armhf-ci/51/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-utopic-i386-ci/51/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/156/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/history-service/information-messageType updated
179. By Tiago Salem Herrmann

fix broken test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/history-service-ci/157/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-utopic-amd64-ci/52/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-utopic-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/history-service-utopic-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-utopic-i386-ci/52

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/157/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
No, but not related to the MR

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches