history-service

Merge lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel into lp://staging/history-service

  1. fix-fetchmore-historygroupedthreadsmodel
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 200
Merged at revision: 205
Proposed branch: lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel
Merge into: lp://staging/history-service
Diff against target: 183 lines (+99/-3)
7 files modified
Ubuntu/History/historygroupedthreadsmodel.cpp (+5/-0)
Ubuntu/History/historythreadmodel.h (+1/-1)
cmake/modules/GenerateTest.cmake (+8/-2)
debian/control (+1/-0)
tests/CMakeLists.txt (+1/-0)
tests/Ubuntu.History/CMakeLists.txt (+14/-0)
tests/Ubuntu.History/HistoryGroupedThreadsModelTest.cpp (+69/-0)
To merge this branch: bzr merge lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+259413@code.staging.launchpad.net

Commit message

Correctly set mCanFetchMore in the HistoryGroupedThreadsModel.

Description of the change

Correctly set mCanFetchMore in the HistoryGroupedThreadsModel.

To post a comment you must log in.
lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel updated
196. By Tiago Salem Herrmann

use isEmpty()

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:196
http://jenkins.qa.ubuntu.com/job/history-service-ci/186/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/24

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/186/rebuild

review: Approve (continuous-integration)
lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel updated
197. By Tiago Salem Herrmann

test canFetchMore()

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:197
http://jenkins.qa.ubuntu.com/job/history-service-ci/187/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/25/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/25/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/187/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel updated
198. By Tiago Salem Herrmann

remove unused modules

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:198
http://jenkins.qa.ubuntu.com/job/history-service-ci/188/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/26/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/188/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel updated
199. By Tiago Salem Herrmann

use dbus

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/history-service-ci/189/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/27/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/28/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/27/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/189/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/history-service/fix-fetchmore-historygroupedthreadsmodel updated
200. By Tiago Salem Herrmann

add xvfb to qml tests

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:200
http://jenkins.qa.ubuntu.com/job/history-service-ci/190/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/29
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/29/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/28

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/190/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:200
http://jenkins.qa.ubuntu.com/job/history-service-ci/191/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/30
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/30/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/29

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/191/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches