history-service

Merge lp://staging/~tiagosh/history-service/fix-1517602 into lp://staging/history-service

  1. fix-1517602
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 221
Merged at revision: 220
Proposed branch: lp://staging/~tiagosh/history-service/fix-1517602
Merge into: lp://staging/history-service
Diff against target: 45 lines (+9/-2)
2 files modified
daemon/historydaemon.cpp (+8/-1)
tests/libhistoryservice/PhoneUtilsTest.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~tiagosh/history-service/fix-1517602
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+277987@code.staging.launchpad.net

Commit message

Allow removing empty threads

Description of the change

Allow removing empty threads

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:220
http://jenkins.qa.ubuntu.com/job/history-service-ci/317/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/155/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/156/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/155/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/317/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~tiagosh/history-service/fix-1517602 updated
221. By Tiago Salem Herrmann

fix broken test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:221
http://jenkins.qa.ubuntu.com/job/history-service-ci/319/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-amd64-ci/157
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/158
        deb: http://jenkins.qa.ubuntu.com/job/history-service-vivid-armhf-ci/158/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/history-service-vivid-i386-ci/157

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/history-service-ci/319/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches