dialer-app

debian/control (+0/-1)
src/dialerapplication.cpp (+1/-1)
src/qml/DialerPage/DialerPage.qml (+42/-12)
src/qml/Dialogs/NoDefaultSIMCardDialog.qml (+2/-2)
src/qml/LiveCallPage/LiveCall.qml (+6/-0)
src/qml/dialer-app.qml (+26/-7)
tests/qml/CMakeLists.txt (+1/-10)
tests/qml/tst_DialerPage.qml (+125/-2)

To merge this branch:

bzr merge lp://staging/~tiagosh/dialer-app/emergency-calls-libphonenumber

Related bugs:

Bug #1308365: [phone-app] press-call-twice-to-redial doesn't work	Low	Fix Released
Bug #1334860: EmergencyNumbers not correctly filled for brazilian operators	High	Fix Released
Bug #1444883: Emergency numbers other than 112 and 911 (and 999 for the UK) are not available in emergency mode	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2015-07-15	Approve on 2015-08-10
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-08-07
Review via email: mp+264908@code.staging.launchpad.net

Commit message

Improve emergency number validation with libphonenumber.

Description of the change

Improve emergency number validation with libphonenumber.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/telephony-service/check-contact-watcher-results/+merge/266631
https://code.launchpad.net/~tiagosh/telephony-service/use-libphonenumber/+merge/264906

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-15:

FAILED: Continuous integration, rev:434
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/580/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/93
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3431
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2857
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3428
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3428/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21884

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/580/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tiagosh/dialer-app/emergency-calls-libphonenumber updated on 2015-07-20

435. By Tiago Salem Herrmann on 2015-07-20: use countryCode when checking for emergency numbers
436. By Tiago Salem Herrmann on 2015-07-20: fix comments

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-20:

FAILED: Continuous integration, rev:436
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/583/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/96
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3452/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2876/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3449
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3449/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/21998

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/583/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tiagosh/dialer-app/emergency-calls-libphonenumber updated on 2015-07-21

437. By Tiago Salem Herrmann on 2015-07-21: Use the selected account if available, otherwise fallback to any other account

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-21:

FAILED: Continuous integration, rev:437
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/584/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/97
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3462
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2882
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3459
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3459/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22036

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/584/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tiagosh/dialer-app/emergency-calls-libphonenumber updated on 2015-07-22

438. By Tiago Salem Herrmann on 2015-07-22: Use string comparison for emergency numbers coming from the sim card

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-07-22:

FAILED: Continuous integration, rev:438
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/585/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/98
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3466
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2885
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3463
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3463/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22067

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/585/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tiagosh/dialer-app/emergency-calls-libphonenumber updated on 2015-07-23

439. By Tiago Salem Herrmann on 2015-07-23: Keep call button always enabled
Fill entry with last called number when the entry is empty and call button is pressed