dialer-app

Merge lp://staging/~tiagosh/dialer-app/add-copy-and-paste into lp://staging/dialer-app

add-copy-and-paste
Merge into trunk

Proposed by Tiago Salem Herrmann on 2016-03-02

Status:

Merged

Approved by:

Gustavo Pichorim Boiko on 2016-03-09

Approved revision:

518

Merged at revision:

515

Proposed branch:

lp://staging/~tiagosh/dialer-app/add-copy-and-paste

Merge into:

lp://staging/dialer-app

Diff against target:

343 lines (+238/-24)

4 files modified

src/qml/DialerPage/KeypadEntry.qml (+41/-17)
src/qml/DialerPage/TextInputPopover.qml (+104/-0)
tests/autopilot/dialer_app/__init__.py (+51/-7)
tests/autopilot/dialer_app/tests/test_dialer.py (+42/-0)

To merge this branch:

bzr merge lp://staging/~tiagosh/dialer-app/add-copy-and-paste

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2016-03-02	Approve on 2016-03-09
PS Jenkins bot	continuous-integration		Needs Fixing on 2016-03-08
Review via email: mp+287845@code.staging.launchpad.net

Commit message

Add support for copy'n'paste to the keypad entry.

Description of the change

Add support for copy'n'paste to the keypad entry.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-03-02:

FAILED: Continuous integration, rev:515
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/634/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/147
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6699
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5085
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6710
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6710/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27967

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/634/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~tiagosh/dialer-app/add-copy-and-paste updated on 2016-03-03

516. By Tiago Salem Herrmann on 2016-03-03: Add autopilot tests

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-03-03:

FAILED: Continuous integration, rev:516
http://jenkins.qa.ubuntu.com/job/dialer-app-ci/635/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-vivid-i386-ci/148
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6706
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5089
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6717
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6717/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27975

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/635/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) on 2016-03-08:

review: Needs Fixing

Revision history for this message

Gustavo Pichorim Boiko (boiko) on 2016-03-08:

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2016-03-08:

Just one thing: if you select all and copy, the selection overlay and handles don't go away. The same happens if you just select all, tap somewhere else on the screen, and then if you press another number, it will look strange on screen.

I think pressing any of the dialpad buttons should clear the selection.

review: Needs Fixing

lp://staging/~tiagosh/dialer-app/add-copy-and-paste updated on 2016-03-08

517. By Tiago Salem Herrmann on 2016-03-08: always remove selection when text changes
518. By Tiago Salem Herrmann on 2016-03-08: add test to check if selection is gone when text is changed