Merge lp://staging/~thumper/launchpad/stack-on-branch-id-alias into lp://staging/launchpad
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Approved by: | Tim Penhey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12874 |
| Proposed branch: | lp://staging/~thumper/launchpad/stack-on-branch-id-alias |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
340 lines (+44/-32) 9 files modified
lib/lp/code/interfaces/codehosting.py (+6/-0) lib/lp/code/model/tests/test_branch.py (+2/-3) lib/lp/code/model/tests/test_branchlookup.py (+8/-5) lib/lp/code/xmlrpc/codehosting.py (+3/-2) lib/lp/code/xmlrpc/tests/test_codehosting.py (+12/-12) lib/lp/codehosting/inmemory.py (+3/-1) lib/lp/codehosting/tests/test_rewrite.py (+5/-6) lib/lp/codehosting/vfs/tests/test_branchfs.py (+2/-1) lib/lp/codehosting/vfs/tests/test_filesystem.py (+3/-2) |
| To merge this branch: | bzr merge lp://staging/~thumper/launchpad/stack-on-branch-id-alias |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
[r=bac][bug=377519] Change the default stacking location to use the branch id alias.
Description of the change
This branch changes the default stacked on location to use the name independent /+branch-id/%(id)s alias.
To post a comment you must log in.
Revision history for this message
| Tim Penhey (thumper) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Tim,
What would you think of a property on IBranch that returned this new value? You construct it a lot here and it'd be nice to do it once.
Approved pending your consideration.