Merge lp://staging/~thumper/launchpad/fix-pending-build-determination into lp://staging/launchpad
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Approved by: | Robert Collins |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 12201 |
| Proposed branch: | lp://staging/~thumper/launchpad/fix-pending-build-determination |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
218 lines (+65/-38) 6 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+1/-1) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+24/-19) lib/lp/code/interfaces/sourcepackagerecipe.py (+4/-5) lib/lp/code/model/sourcepackagerecipe.py (+16/-8) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+15/-0) lib/lp/code/scripts/tests/test_request_daily_builds.py (+5/-5) |
| To merge this branch: | bzr merge lp://staging/~thumper/launchpad/fix-pending-build-determination |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Collins (community) | Approve | ||
|
Review via email:
|
|||
Commit message
[r=lifeless]
Description of the change
Some recipe builds were getting stuck at the top of the list on the main recipe page. This is due to an incorrect query to determine pending builds.
I also refactored the getBuilds method so it doesn't take a boolean parameter to change the behaviour. I found this very confusing while reading the browser code.
To post a comment you must log in.
Revision history for this message
| Robert Collins (lifeless) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
