Merge lp://staging/~thumper/launchpad/code-email-permissions into lp://staging/launchpad/db-devel
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Approved by: | Tim Penhey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~thumper/launchpad/code-email-permissions |
| Merge into: | lp://staging/launchpad/db-devel |
| Diff against target: |
51 lines (+30/-0) 2 files modified
database/schema/security.cfg (+1/-0) lib/lp/code/mail/tests/test_codehandler.py (+29/-0) |
| To merge this branch: | bzr merge lp://staging/~thumper/launchpad/code-email-permissions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Hudson-Doyle | Approve | ||
|
Review via email:
|
|||
Commit message
Add codeimport to the select permissions for processmail.
Description of the change
Add a missing db permission for people trying to approve a branch using email.
tests:
test_
No pre-impl call, somewhat trivial.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yes, seems fine. I'm not entirely sure this bit:
25 + The permission check needs to fall through from the owner, that is why
26 + we are using a non-reviewer for this test.
makes complete sense, can you expand it a bit?
Thanks for doing this and cooking up the test though :-)