Merge lp://staging/~thumper/launchpad/branch-index-slowness into lp://staging/launchpad
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Approved by: | Tim Penhey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11000 |
| Proposed branch: | lp://staging/~thumper/launchpad/branch-index-slowness |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
436 lines (+166/-26) 14 files modified
lib/lp/code/browser/branch.py (+105/-14) lib/lp/code/browser/tests/test_branch.py (+33/-1) lib/lp/code/configure.zcml (+1/-0) lib/lp/code/interfaces/branch.py (+3/-0) lib/lp/code/model/branch.py (+11/-0) lib/lp/code/templates/branch-import-details.pt (+1/-1) lib/lp/code/templates/branch-management.pt (+1/-1) lib/lp/code/templates/branch-metadata.pt (+1/-1) lib/lp/code/templates/branch-pending-merges.pt (+1/-1) lib/lp/code/templates/branch-portlet-subscribers.pt (+1/-1) lib/lp/code/templates/branch-recipes.pt (+1/-1) lib/lp/code/templates/branch-related-bugs-specs.pt (+1/-1) lib/lp/code/templates/branch-revisions.pt (+2/-2) lib/lp/testing/factory.py (+4/-2) |
| To merge this branch: | bzr merge lp://staging/~thumper/launchpad/branch-index-slowness |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Fix time-outs on the branch index page for branches with lots of linked bugs.
Description of the change
This branch provides a DecoratedBranch object to cache database queries. An extra method is added to the branch class to get linked bugs and all their bug tasks.
As a part of this branch, only bugs in an incomplete state are shown on series branches.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
<rockstar> thumper, line 150 of your diff, why not use isinstance?
<thumper> rockstar: because I didn't think of it :)
<rockstar> thumper, okay. Can you remedy that?
<thumper> yep
<rockstar> thumper, do you have some data to go with this branch that might be good to go to the list?
<thumper> rockstar: what are you asking exactly
<rockstar> thumper, I think query count numbers along with the changes in this branch would be good to post to the list.
<thumper> rockstar: I'll be writing something up, yes