Merge lp://staging/~thumper/launchpad/anon-http-branch-id-access into lp://staging/launchpad
Proposed by
Tim Penhey
| Status: | Merged |
|---|---|
| Merged at revision: | 12758 |
| Proposed branch: | lp://staging/~thumper/launchpad/anon-http-branch-id-access |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
254 lines (+139/-8) 5 files modified
lib/lp/code/interfaces/codehosting.py (+4/-0) lib/lp/code/model/branchlookup.py (+35/-7) lib/lp/code/model/tests/test_branchlookup.py (+44/-0) lib/lp/codehosting/rewrite.py (+5/-1) lib/lp/codehosting/tests/test_rewrite.py (+51/-0) |
| To merge this branch: | bzr merge lp://staging/~thumper/launchpad/anon-http-branch-id-access |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
This branch is the start of a pipeline to fix the problem
where branches that are stacked on another branch that changes
any part of the branch unique_name get broken.
The solution is instead to stack on an ID based url.
This branch adds support for a +branch-id/%(id)s branch alias
for public branches served over HTTP using the rewrite script.
To post a comment you must log in.
Revision history for this message
| Graham Binns (gmb) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Whoops, helps if you actually post your review comments, doesn't it?
This branch is fine but all of the tests in lib/lp/