Merge lp://staging/~thumper/golxc/mockable into lp://staging/golxc

Please take a look.

Also added license files and headers.

Also, perhaps we could change ownership of trunk to ~juju-core?

Trivials:

English:
931 + // Clone creates a copy of the container, it gets the given name.
932 + Clone(name string) (Container, error)

Perhaps: // Clone creates a copy of the container, giving the copy the specified name.

962 + // LogLevel returns the current logging level, this is only used if the
963 + // LogFile is not "".
964 + LogLevel() LogLevel

Perhaps: // LogLevel returns the current logging level (only used if the LogFile is not "").

Also, some comments have "." at the end, others don't.

 +// ContainerFactory represents the methods used to create Containers.
971 +type ContainerFactory interface {
972 + // New returns a container instance which can then be used for operations
973 + // like Create(), Start(), Stop() or Destroy().
974 + New(string) Container
975 + List() ([]Container, error)
976 +}

Please add a comment for List(). I know there's one on the method implementation, but the interface is where you really want to see the comment.

On 14/06/13 12:51, Ian Booth wrote:
> Review: Approve
>
> Trivials:
>
> English:
> 931 + // Clone creates a copy of the container, it gets the given name.
> 932 + Clone(name string) (Container, error)
>
> Perhaps: // Clone creates a copy of the container, giving the copy the specified name.

Done.

> 962 + // LogLevel returns the current logging level, this is only used if the
> 963 + // LogFile is not "".
> 964 + LogLevel() LogLevel
>
> Perhaps: // LogLevel returns the current logging level (only used if the LogFile is not "").
>
> Also, some comments have "." at the end, others don't.

I think they should be valid sentences.

> +// ContainerFactory represents the methods used to create Containers.
> 971 +type ContainerFactory interface {
> 972 + // New returns a container instance which can then be used for operations
> 973 + // like Create(), Start(), Stop() or Destroy().
> 974 + New(string) Container
> 975 + List() ([]Container, error)
> 976 +}
>
> Please add a comment for List(). I know there's one on the method implementation, but the interface is where you really want to see the comment.

Done.

In a discussion we decided to just wrap the needed LXC commands inside juju-core, but it's nice to see this package alive and with these good changes.