Juju Charms Collection
dns package

Merge lp://staging/~thomnico/charms/precise/dns/openport53 into lp://staging/~lazypower/charms/precise/dns/trunk

  1. Precise Pangolin (12.04)
  2. openport53
  3. Merge into trunk
Proposed by Nicolas Thomas
Status: Approved
Approved by: Charles Butler
Approved revision: 13
Proposed branch: lp://staging/~thomnico/charms/precise/dns/openport53
Merge into: lp://staging/~lazypower/charms/precise/dns/trunk
Diff against target: 11 lines (+3/-1)
1 file modified
contrib/bind/install.py (+3/-1)
To merge this branch: bzr merge lp://staging/~thomnico/charms/precise/dns/openport53
Reviewer Review Type Date Requested Status
Charles Butler Approve
Review via email: mp+261493@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

Hey Nicolas,

Thanks for the MP. One thing - Im actually tracking upstream development in GitHub here: https://github.com/chuckbutler/dns-charm

Ill be happy to merge this and backport it to HEAD. but in the future if you could target the merges there it would be a big help with my workflow.

Thanks a bunch for the contribution!

review: Approve
Reply
Revision history for this message
Charles Butler (lazypower) wrote :

Ive merged this on github

https://github.com/chuckbutler/DNS-Charm/commit/2e9aff554960ca669f17e050bba6002c37906157

and will tag + release this with the next round of features. Thanks again Nicolas!

Reply
Revision history for this message
Nicolas Thomas (thomnico) wrote :

Hi Charles,

Will go on github from now .. no issue .. I just get lost on which is
priming versus chamrstore per project .. sorry...

Is the github to charmstore process automated for this ?? many stuff will
benefit from that

On Wed, Jun 10, 2015 at 1:14 AM, Charles Butler <
<email address hidden>> wrote:

> The proposal to merge lp:~thomnico/charms/precise/dns/openport53 into
> lp:~lazypower/charms/precise/dns/trunk has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
>
> https://code.launchpad.net/~thomnico/charms/precise/dns/openport53/+merge/261493
> --
> You are the owner of lp:~thomnico/charms/precise/dns/openport53.
>

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Reply
Revision history for this message
Charles Butler (lazypower) wrote :

Not yet, but it will be in the future. juju charm publish will allow you to publish an arbitrary bin/tar of your charm code, so it gets decoupled from VCS.

Reply
Revision history for this message
Nicolas Thomas (thomnico) wrote :

Can you be so kind to push it to charm store ?? I see code in git but
juju deploy dns
get the old one and I can not connect to my real life dns with it, thanks

On Wed, Jun 10, 2015 at 8:34 PM, Charles Butler
<email address hidden> wrote:
> Not yet, but it will be in the future. juju charm publish will allow you to publish an arbitrary bin/tar of your charm code, so it gets decoupled from VCS.
>
>
> --
> https://code.launchpad.net/~thomnico/charms/precise/dns/openport53/+merge/261493
> You are the owner of lp:~thomnico/charms/precise/dns/openport53.

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Reply

Unmerged revisions

13. By Nicolas Thomas

Open port 53 in udp to allow connecting to upstream/real dns service.

modified:
  contrib/bind/install.py

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: