core result checker

Merge lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-detect-adt-status-and-republish-maybe into lp://staging/core-result-checker

  1. trunk-detect-adt-status-and-republish-maybe
  2. Merge into trunk
Proposed by Thomi Richards
Status: Merged
Approved by: Thomi Richards
Approved revision: 12
Merged at revision: 12
Proposed branch: lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-detect-adt-status-and-republish-maybe
Merge into: lp://staging/core-result-checker
Diff against target: 95 lines (+49/-3)
1 file modified
core_result_checker/__init__.py (+49/-3)
To merge this branch: bzr merge lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-detect-adt-status-and-republish-maybe
Reviewer Review Type Date Requested Status
Francis Ginther Needs Information
Celso Providelo (community) Approve
Review via email: mp+255316@code.staging.launchpad.net

Commit message

Requeue tests if infrastructure failed.

Description of the change

Re-queue test payloads into core.tess.v1 if the adt exit_code indicates an infrastructure error.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) :
review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

This looks wrong to me:

56 + q = self.connection.SimpleQueue(
57 + "core.tests.{}".format(constants.API_VERSION)
58 + )

Shouldn't the core.tests queue match the version that the previously ran this payload? Using the core-result-checker's API_VERSION would cause us to send messages to the wrong queue should the core-image-tester's API_VERSION get out of sync.

Do we actually need to have the name of the core-image-tester queue added to the payload so that the core-result-checker knows where to resend it?

review: Needs Information
Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

result-checker only binds core.results.v1 queue, i.e. the v1 contract is common to all processed messages, thus re-posting on core.tests.v1 makes sense.

Versioned queues will only allow us to deploy new isolated solution pipelines (watcher->publisher->tester->checker) in the same amqp server, not necessarily mix them.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: