Merge lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-check-swift-better into lp://staging/core-result-checker
Proposed by
Thomi Richards
| Status: | Merged |
|---|---|
| Approved by: | Thomi Richards |
| Approved revision: | 15 |
| Merged at revision: | 13 |
| Proposed branch: | lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-check-swift-better |
| Merge into: | lp://staging/core-result-checker |
| Diff against target: |
175 lines (+78/-18) 1 file modified
core_result_checker/__init__.py (+78/-18) |
| To merge this branch: | bzr merge lp://staging/~thomir-deactivatedaccount/core-result-checker/trunk-check-swift-better |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Celso Providelo (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Wait for swift to be consistent.
Description of the change
Add a check for swift to become consistent before we try and make the container public.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Right, let's see the SwiftManager in action.
I just think that 10 minutes spinning message waiting for swift seems excessive (I can see the logging storm already), but we shall see ...
For situations like this I'd prefer moving jobs quickly (< 30 s) to the deadletter queue and have proper monitoring and replay scripts.